PieFed Meta

1031 readers

29 users here now

Discuss PieFed project direction, provide feedback, ask questions, suggest improvements, and engage in conversations related to the platform organization, policies, features, and community dynamics.

Wiki

founded 1 year ago

MODERATORS

rimu@piefed.social

CORS doesn't work on the piefed API (europe.pub)

submitted 1 week ago by aeharding@vger.social to c/piefed_meta@piefed.social

10 comments fedilink hide all child comments

Not sure where to post this: the Piefed API doesn't support CORS, at least testing against piefed.social, so requests from webapps like photon, alexandrite, voyager via PWA would not work.

Also, is there a way to pass a fedilink to resolve, like Lemmy resolveObject?

And lastly, how is Piefed planning on handling updates to the API for lemmy v1? Things like varying object type arrays being combined, and new/updated sorts.

Thanks!

you are viewing a single comment's thread
view the rest of the comments

[–] rimu@piefed.social 11 points 1 week ago (4 children)

I've added CORS now :)

[–] keepthepace@slrpnk.net 2 points 3 days ago* (last edited 3 days ago)

[–] aeharding@vger.social 3 points 5 days ago (1 children)

I checked piefed.social and I'm still getting CORS errors. Does the change still have yet to be deployed there?

[–] rimu@piefed.social 3 points 4 days ago (1 children)

It's working for me. Try this:

<!-- Save this as test-cors.html and open in a browser -->
<!DOCTYPE html>
<html>
  <body>
    <script>
      fetch("https://piefed.social/api/alpha/comment?id=6527216", {
        method: "GET", // or "POST", etc.
        headers: {
          "Content-Type": "application/json"
        }
      })
      .then(response => response.text())
      .then(data => console.log("Success:", data))
      .catch(error => console.error("CORS Error:", error));
    </script>
  </body>
</html>

[–] aeharding@vger.social 3 points 4 days ago* (last edited 4 days ago) (1 children)

Ah, that works, but this doesn't:

<!-- Save this as test-cors.html and open in a browser -->
<!DOCTYPE html>
<html>
  <body>
    <script>
      fetch("https://piefed.social/comment/6527914", {
        method: "GET", // or "POST", etc.
        headers: {
          "Content-Type": "application/json",
          Accept: "application/activity+json",
        },
      })
        .then((response) => response.text())
        .then((data) => console.log("Success:", data))
        .catch((error) => console.error("CORS Error:", error));
    </script>
  </body>
</html>

nor this:

<!-- Save this as test-cors.html and open in a browser -->
<!DOCTYPE html>
<html>
  <body>
    <script>
      fetch("https://piefed.social/.well-known/nodeinfo", {
        method: "GET", // or "POST", etc.
        headers: {
          "Content-Type": "application/json"
        },
      })
        .then((response) => response.text())
        .then((data) => console.log("Success:", data))
        .catch((error) => console.error("CORS Error:", error));
    </script>
  </body>
</html>

[–] rimu@piefed.social 3 points 4 days ago

Ok technically those are not part of the API ;-)

I've put CORS headers on everything now, go for it.

[–] aeharding@vger.social 5 points 1 week ago

Nice, thanks! I’ll try it again soon

[–] Blaze@piefed.social 1 points 1 week ago

@aeharding@vger.social test