Apparently NY state allows felons to vote as long as they are not in prison, and Florida defers to the law where the crime was committed, so Trump is allowed to vote in Florida where is "home" is.
The real question isn't why he's allowed to vote, but why he's not in prison. Felons should be allowed to vote, otherwise it would be trivial to lock your opponents out of eligibility through lawfare.