top 50 comments

sorted by: hot top controversial new old
[–] 178 points 8 months ago (40 children)

I'll say this now.

Inheritance is the most misused capability of OOP which programmers think makes their code look smart, but most of the time just makes a giant fucking mess.

  • source
  • hideshow 40 child comments
  • [–] 106 points 8 months ago* (10 children)

    Hold on, I’m in the middle of drawing an inheritance graph so I know how Dog is related to AircraftCarrier.

  • source
  • parent
  • hideshow 10 child comments
  • [–] 79 points 8 months ago* (9 children)
    public interface ICanTravelThroughTheAir
    {
    
    }
    
    public class Flea : ICanTravelThroughTheAir
    {
    
    }
    
    public class AircraftCarrier
    {
      private readonly List<ICanTravelThroughTheAir> _aircraft = new();
    
      public void AddAircraft(ICanTravelThroughTheAir flyingThing)
      {
        _aircraft.Add(flyingThing);
      }
    }
    
    public class Dog : AircraftCarrier
    {
        public void Woof()
        {
            Console.WriteLine("Bitch I'm an aircraft carrier!");
        }
    }
    
    public static class Program
    {
      public int Main(string[] args)
      {
        var dog = new Dog();
        
        for (var i = 0; i < 10000; i++)
        {
            dog.AddAircraft(new Flea());
        }
    
        dog.Woof();
      }
    }
    
  • source
  • parent
  • hideshow 9 child comments
  • [–] 64 points 8 months ago (4 children)

    Needs more AbstractDefaultProxyBeanFactoryFactories

  • source
  • parent
  • hideshow 4 child comments
  • [–] 24 points 8 months ago (2 children)

    And dependency injection!

    Every class needs to use DI for calling other classes, even though we'll have anyway just a single implementation for all of them, and we won't be using this flexibility at all (not even for tests where it might be useful for mocking dependencies).

  • source
  • parent
  • hideshow 2 child comments
  • load more comments (1 reply)
  • load more comments (1 reply)
  • load more comments (3 replies)
  • [–] 46 points 8 months ago (20 children)

    Its the best/worst thing about OOP no matter what language.

    We had a rule at work that if you are 3 levels or more down an inheritance tree, then you are too far. The cognitive load is just too much, plus everything stops making sense.

    One level can be great (MVC all have great conventions, MCP as well). Two can be pushing it (Strategy pattern when you have physical devices and cant be connected all the time, Certain kinds of business logic that repeat hundreds of times, etc...) But even there you are kinda pushing it.

    I need code that I can look at a month from now and know WTF is happening. And sometimes its better to have less DRY and more comprehension. Or maybe im just a forever mediocre dev and dont see the "light". I dunno.

  • source
  • parent
  • hideshow 20 child comments
  • [–] 20 points 8 months ago (5 children)

    This is exactly how I feel too. A little bit of repetition is totally worth it, versus having inappropriate coupling, or code that jumps in and out of parent/child classes everywhere so you can hardly keep it in your head what's going on.

    I freely accept that I AM a mediocre dev, but if that lends me to prefer code that is comprehensible and maintainable then I think being mediocre is doing my team a favour, honestly.

  • source
  • parent
  • hideshow 5 child comments
  • load more comments (3 replies)
  • [–] 10 points 8 months ago (2 children)

    I learned about it in school and we didna few assignments for it

    But.. never seen or heard anyone mention it outside of that

    I guess we can make up some nische vases

    I did hear it can be useful for video games though. But then again im sure people can manage fint without, as well

  • source
  • parent
  • hideshow 2 child comments
  • [–] 14 points 8 months ago

    It's wildly useful, when you store a lot of similar stuff, or treat a lot of similar stuff etc.

    Like a GUI, a rendering engine or a scientific soft. Video games, any soft with users, and so on.

    I get that people misuse it but for me it's wild that people think you should like program without it, like at all cost.

  • source
  • parent
  • [–] 6 points 8 months ago

    We use it a lot when we have a solution that works for 95% of customers and a few need random things.

    Else we will have multiple markets changing the same function with a thousand if else

    Main issue is that makes it so that some functions are never generalized, like when customer A wanted to use an equal filter, customer B wanted a IN filter, and the rest have no filtering capability at all.

  • source
  • parent
  • [–] 5 points 8 months ago*

    I've moved away from Classes in general unless it truly makes code more streamlined. The main language I was taught in highschool was Java and it's just so liberating not needing to turn everything into an object.

    But recently I've used a Class specifically for Inheritance. I'm making an extension to Pytorch and almost everything in Pytorch uses Tensors as a medium. I made a new kind of tensor that inherits the Tensor class to add specific restrictions on how it behaves. Because of this, this new tensor object can be used with any of the preexisting pytorch functions while also validating the results, reverting to a Tensor if it becomes invalid.

    Even in this situation though, all my programming logic rests in it's own static functions, and the class contains functions that call the static version. The only actual logic the inherited object handles is validating the data.

    Because of this, I feel like inheritance is most useful when you're inheriting someone else's code to make it compatible with their library. I don't think I'll ever inherit my own objects because that's how you end up with Java.

  • source
  • parent
  • [–] 4 points 8 months ago

    And polymorphism is the only way you could expose those composite Interfaces as bindings on C API based languages. And polymorphism is part of OOP.

    If we take the text book definition of OOP, then the kernel is OOP ...

  • source
  • parent
  • load more comments (1 reply)
    [–] 83 points 8 months ago (16 children)

    In over ten years of professional programming, I have never used inheritance without regretting it.

  • source
  • hideshow 16 child comments
  • [–] 6 points 8 months ago

    It might be nice to use in some very specific cases (e.g. addition-operation is a binary-operation AST node which is an AST node).

    In most of the cases it just creates noise though, and you can usually do something different anyway to implement the same feature. For example in rust, just use enums and list all the possible cases and it's even nicer to use than inheritance.

  • source
  • parent
  • load more comments (4 replies)
    [–] 65 points 8 months ago

    Composition over inheritance every day, all day

  • source
  • [–] 62 points 8 months ago* (3 children)

    I LOVE TRAITS. YOU'LL HAVE TO TAKE THEM FROM MY COLD DEAD HANDS

    [Insert SpongeBob screaming meme]

  • source
  • hideshow 3 child comments
  • [–] 10 points 8 months ago (2 children)

    TRAITS ARE SO USEFUL AND STRUCTS ARE EASILY REPRESENTED IN MEMORY AND WORKED WITH, COMBINED THEY WILL TAKE OVER THE LINUX KERNEL AND THE WORLD

  • source
  • parent
  • hideshow 2 child comments
  • [–] 49 points 8 months ago (2 children)

    The venerable master Qc Na was walking with his student, Anton. Hoping to prompt the master into a discussion, Anton said "Master, I have heard that objects are a very good thing - is this true?" Qc Na looked pityingly at his student and replied, "Foolish pupil - objects are merely a poor man's closures."

    Chastised, Anton took his leave from his master and returned to his cell, intent on studying closures. He carefully read the entire "Lambda: The Ultimate..." series of papers and its cousins, and implemented a small Scheme interpreter with a closure-based object system. He learned much, and looked forward to informing his master of his progress.

    On his next walk with Qc Na, Anton attempted to impress his master by saying "Master, I have diligently studied the matter, and now understand that objects are truly a poor man's closures." Qc Na responded by hitting Anton with his stick, saying "When will you learn? Closures are a poor man's object." At that moment, Anton became enlightened.

  • source
  • hideshow 2 child comments
  • [–] 41 points 8 months ago (3 children)

    Deref is for smart pointers and not for inheritance.

  • source
  • hideshow 3 child comments
  • [–] 4 points 8 months ago

    The windows crate is full of Deref. Because the windows API is full of inheritance.

    It may not be what the trait was thought of for, but I'm glad we have it to interface with APIs that have actual inheritance.

  • source
  • parent
  • load more comments (1 reply)
    [–] 38 points 8 months ago* (10 children)

    In case anyone is wondering:

    The artist is Princess Hinghoi.

  • source
  • hideshow 10 child comments
  • [–] 15 points 8 months ago* (3 children)

    Examples of inheritance hierarchies are always totally useless shit like this - what if a cow is an animal; What if a cow is a mammal, all mammals are animals and all mammals have a lactate() method?

  • source
  • hideshow 3 child comments
  • [–] 10 points 8 months ago

    Because any real life use that might come to mind would probably be related to some NDA protected database in a company.
    And it is otherwise hard to think of anything at the spot, so just go with what the first example on the web-search came up with.

  • source
  • parent
  • [–] 14 points 8 months ago

    Entity Component System all the things!

    I might write an XML ECS parser, as a joke. Practical? No! Probably even slower than the XML DOM? Yes! Funny? Yes!

  • source
  • load more comments
    view more: next ›