981
Peer reviewing is torture now (europe.pub)
submitted 2 weeks ago by to c/programmer_humor@programming.dev
137 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[–] 13 points 2 weeks ago* (4 children)

is it auto reject, or just doesn't auto approve and leaves it open for manual review

It seems weird that you can't do a pr at all with 1000 line changes, any moderate size feature addition could hit that mark

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] 6 points 2 weeks ago (2 children)

    You know, you could just chunk it up in a way to keep it readable.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 9 points 2 weeks ago* (last edited 2 weeks ago) (1 child)

    for a new feature request? a PR isn't a commit, it's a set of commits which would add to the line change amount.

    Like even if you spread it out across 20 or 30 commits that's still going to be the same line count.

    I guess you could push not yet functional or used code to lessen the line count change, but that seems in bad taste. I've always gone off the working repo should always be in build or clean state and a push or commit shouldn't break that.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 1 child comment
    •
  • [–] 5 points 2 weeks ago*

    I work in a Scrum team and we implement features iteratively, so we start with the minimal feature, merge it, get feedback, and go on from there.

    At work there's no excuse to keep a feature in a stale branch until you accumulate 1000 lines of code change.

  • permalink
  • fedilink
  • source
  • parent