top 50 comments

sorted by: hot top controversial new old
[–] 119 points 2 weeks ago (5 children)

Don't worry half of those will be useless code comments

  • source
  • hideshow 5 child comments
  • [–] 131 points 2 weeks ago (4 children)

    // Here I'm not using that other thing that is now completely irrelevant, but I'll leave a comment to the non-existing thing anyway because I'm avoiding it.

  • source
  • parent
  • hideshow 4 child comments
  • load more comments (1 reply)
  • [–] 103 points 2 weeks ago

    Repeat after me: "Rejected. Reason: too large of a change for one PR."

  • source
  • [–] 99 points 2 weeks ago (13 children)

    I struggle to review a 1k line change. When people give me such big changes I normally don't believe they've reviewed them either.

  • source
  • hideshow 13 child comments
  • [–] 20 points 2 weeks ago (3 children)

    Try working on a codebase that's all event-driven hexagonal CQRS with hand-crafted SQL for persistence. Add additional buzzwordy methodologies to taste.

    Adding a single property to your product means you now have to update an aggregate class, several DTOs, and several event classes and handlers before you can even think about touching the UI.

    And that's in your main solution. There's also at least one facade service you'll need to make compatible and you also need to update the event simulator used for testing. The latter night involve having to touch every single line in a 2000 lines long SQL script.

    Having to go though three separate 600-2000 LOC PRs for one PBI isn't that exotic.

  • source
  • parent
  • hideshow 3 child comments
  • load more comments (1 reply)
  • load more comments (7 replies)
    [–] 89 points 2 weeks ago (28 children)

    The problem with Claude is that it doesn't write code to be modular & reusable. Every tiny change requires a complete rewrite.

  • source
  • hideshow 28 child comments
  • [–] 69 points 2 weeks ago (10 children)

    I've completely banned any code that can't be explained. I've had my CTO send me code at 3 AM to implement and when I ask him what I'm looking at he just says it doesn't need review, just push it.

    Uhh, no sir, I'm not doing shit because you've handed me GCC and we're MSVC.

    After I bitched endlessly to the CEO about that he said I have final say on what goes into the project.

  • source
  • parent
  • hideshow 10 child comments
  • [–] 28 points 2 weeks ago (7 children)

    I've had my CTO send me code at 3 AM

    I hope you don't even respond until your next normal working hours!

  • source
  • parent
  • hideshow 7 child comments
  • [–] 16 points 2 weeks ago (6 children)

    I love my job, even when I have to deal with nonsense like that and I'm compensated very well to be on call 24/7.

  • source
  • parent
  • hideshow 6 child comments
  • load more comments (5 replies)
  • load more comments (1 reply)
  • load more comments (17 replies)
    [–] 60 points 2 weeks ago (9 children)

    No

    You ask your LLM of choice to look it over, completing the shit-cycle

  • source
  • hideshow 9 child comments
  • [–] 19 points 2 weeks ago (7 children)

    I fully expect this to become the new normal being pushed by management.

    "We identified PR reviews to be blocking our newfound AI-powered efficiency, so we are now mandating all the reviews to done by AI. Also we figured all the developers are now useless since all you do is ask Claude to solve tickets, so you are all fired"

    I wonder how long it takes for the first high profile disaster happening because of a policy like that.

  • source
  • parent
  • hideshow 7 child comments
  • load more comments (7 replies)
  • load more comments (1 reply)
    [–] 45 points 2 weeks ago (5 children)

    We've had a very recent uptick in engineers submitting PRs of hundreds of lines across multiple files, for Jira tickets that only asked for a one-line change. The engineers involved have been using AI assistants for nearly two years now, but there seems to have been a change in the last month or so in how aggressive the new models are at changing code.

  • source
  • hideshow 5 child comments
  • load more comments (3 replies)
    [–] 42 points 2 weeks ago (3 children)
  • [–] 40 points 2 weeks ago (1 child)

    That's an automatic reject from me, that's not a patch, it's an overhaul

  • source
  • hideshow 1 child comment
  • load more comments (1 reply)
    [+] 40 points 2 weeks ago* (last edited 1 week ago) (18 children)
  • load more comments (15 replies)
    [–] 37 points 2 weeks ago

    🛑 Changes requested

    Too big. Break into smaller individual PRs.

  • source
  • [–] 32 points 2 weeks ago (1 child)

    If you can't be bothered to write your own code, I can't be bothered to review

  • source
  • hideshow 1 child comment
  • load more comments (1 reply)
    [–] 32 points 2 weeks ago (12 children)

    Merge that shit, watch it all collapse, enjoy your forever holiday

  • source
  • hideshow 12 child comments
  • [–] 14 points 2 weeks ago (11 children)

    "So, Daywim. Why did you let this obviously aweful PR pass your desk causing so much trouble for our company? I'm afraid we have to let you go because of this questionable performance." - Corporate

  • source
  • parent
  • hideshow 11 child comments
  • [–] 10 points 2 weeks ago (7 children)

    "Looks like I overlooked something in this 6k PR full of im meaningless dribble. Why don't you ask the person who comitted the code how he overlooked this bug. Its his respinsibility"

    Just throw the the slop creator under the bus.

  • source
  • parent
  • hideshow 7 child comments
  • [–] 30 points 2 weeks ago (8 children)

    Our PR checks auto reject the PR if it has 1k changes

  • source
  • hideshow 8 child comments
  • load more comments (3 replies)
    [–] 30 points 2 weeks ago

    It is not even peer review anymore, unless we are pretending that claude is our peer.

  • source
  • [–] 25 points 2 weeks ago* (1 child)

    Yep.

    We have one PR still blocked. Last change is a simple comment from me “Why ?”

  • source
  • hideshow 1 child comment
  • [–] 15 points 2 weeks ago

    No Mr Bond, i expect you to approve

  • source
  • [–] 13 points 2 weeks ago* (2 children)

    If LLM can make big PR, LLM can split PRs

  • source
  • hideshow 2 child comments
  • load more comments (1 reply)
    [–] 11 points 2 weeks ago

    And people were already annoyed when I had ~90 changes due to refactoring and fixing imports ...

  • source
  • [–] 10 points 2 weeks ago (2 children)

    This is a joke I'm not college educated enough to understand.

  • source
  • hideshow 2 child comments
  • load more comments (1 reply)
    load more comments
    view more: next ›